premake: Define VST2 boilerplate cpp-files explictly #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the boilerplate cpp-files are not enumerated explicitly in premake5.lua, and if any of them is missing, the plugin will compile without errors but obviously won't load. Signed-off-by: Jarkko Sakkinen <[email protected]>
VST2 boileplate cpp-files inside the VST3 SDK had an incorrect path, which went silent from the build system. Enumerate the needed boilerplate cpp-files explicitly so that the build system will always give us an error if any of the files are missing. However, comment the files out because compiling vst2wrapper.cpp will result the following compiler error (Linux/GCC): vst3sdk/public.sdk/source/vst/basewrapper/basewrapper.cpp: In member function ‘virtual bool Steinberg::Vst::BaseEditorWrapper::_open(void*)’: vst3sdk/public.sdk/source/vst/basewrapper/basewrapper.cpp:197:32: error: ‘type’ was not declared in this scope return mView->attached (ptr, type) == kResultTrue; Signed-off-by: Jarkko Sakkinen <[email protected]>
|
Probably a good practice/balance with premake5 would be to use explicit paths for any external boilerplate files and wildcards for the internal files. The main build recipe won't explode but we still get proper compiler errors when something is missing. |
|
@asimilon - query, are bits in this PR something that help with https://github.com/asimilon/surge/commits/macOS_VST2_build ? |
Just set userDataPath to the fixed ~/Documents/Surge location. Signed-off-by: Jarkko Sakkinen <[email protected]>
kzantow
approved these changes
Dec 16, 2018
|
@jsakkine all this has been added to #92 so you might wanna close this PR.. |
Add a new target to premake5.lua called app that builds a standalone application. Surge (and VSTGUI) files are linked to the final executable but it does not do anything useful yet. This just the initial plumbing needed. In addition, the target is only available on Linux. This is done purpose. It is better to make it first work on one platform, and after it is fully working, scale it to the other platforms. They are easy to add once app itself is not a moving platform. Linux is the most reasonable choice for this because on that platform the standalone app is most desperately needed for development as plugin targets do not work properly yet. Then, at least one target will support Linux and probably the plugin issues get more easily fixed. Signed-off-by: Jarkko Sakkinen <[email protected]>
baconpaul
added a commit
that referenced
this pull request
Dec 19, 2018
Duplicate of #70 expand vst2 file list
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Duplicate of surge-synthesizer#70 expand vst2 file list Former-commit-id: d22dcae Former-commit-id: 003ed52322f1d92e63c184cf8b569540d6458587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the boilerplate cpp-files are not enumerated explicitly in premake5.lua,
and if any of them is missing, the plugin will compile without errors but
obviously won't load.
Signed-off-by: Jarkko Sakkinen [email protected]