Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate of #70 #111

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Duplicate of #70 #111

merged 2 commits into from
Dec 19, 2018

Conversation

jarkkojs
Copy link
Collaborator

@jarkkojs jarkkojs commented Dec 19, 2018

I closed #70 because these were supposed to be part of a bigger PR but did not find them so here they are again.

If the boilerplate cpp-files are not enumerated explicitly in premake5.lua,
and if any of them is missing, the plugin will compile without errors but
obviously won't load.

Signed-off-by: Jarkko Sakkinen <[email protected]>
VST2 boileplate cpp-files inside the VST3 SDK had an incorrect path,
which went silent from the build system.  Enumerate the needed
boilerplate cpp-files explicitly so that the build system will always
give us an error if any of the files are missing.

However, comment the files out because compiling vst2wrapper.cpp will
result the following compiler error (Linux/GCC):

vst3sdk/public.sdk/source/vst/basewrapper/basewrapper.cpp: In member function ‘virtual bool Steinberg::Vst::BaseEditorWrapper::_open(void*)’:
vst3sdk/public.sdk/source/vst/basewrapper/basewrapper.cpp:197:32: error: ‘type’ was not declared in this scope
   return mView->attached (ptr, type) == kResultTrue;

Signed-off-by: Jarkko Sakkinen <[email protected]>
@esaruoho
Copy link
Collaborator

@baconpaul any cjance this could land?-)

@esaruoho esaruoho mentioned this pull request Dec 19, 2018
@baconpaul
Copy link
Collaborator

Sure sorry we missed that merge. Pulling it in. I can't test it since I don't build VST2 but it looks like an equiv to me. If there's a VST2 error as a result let me flag @asimilon and @kzantow who are building that.

@baconpaul baconpaul merged commit d22dcae into surge-synthesizer:master Dec 19, 2018
baconpaul added a commit to baconpaul/surge that referenced this pull request Jul 10, 2019
Duplicate of surge-synthesizer#70 expand vst2 file list

Former-commit-id: d22dcae
Former-commit-id: 003ed52322f1d92e63c184cf8b569540d6458587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants