Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch-based input issues #5802

Closed
3 tasks done
mkruselj opened this issue Jan 19, 2022 · 2 comments · Fixed by #5979
Closed
3 tasks done

Touch-based input issues #5802

mkruselj opened this issue Jan 19, 2022 · 2 comments · Fixed by #5979
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 19, 2022

So this one is gonna be a bit difficult to explain, but using my Surface Pro 4, I can notice these weirdities:

  • Context menus (i.e. patch browser, filter type, osc type, FX type, main menu) don't always open under the location where I pressed
  • Long press to right click doesn't work
  • Touchscreen mode doesn't set the mouse sensitivity to Exact in the back end, so if we're at default Legacy setting, moving sliders doesn't follow finger movement either
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Jan 19, 2022
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Jan 19, 2022
mkruselj added a commit to mkruselj/surge that referenced this issue Jan 19, 2022
@baconpaul
Copy link
Collaborator

So the long-press-to-right-click after seeing jatin's solution is really just a timer.
maybe i could do that so it printed in the slider on a long hold and you could go from there?
sound good?

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 20, 2022
1. Add a LongHoldMixin
2. Implement that on slider
3. In touch mode, as a result, you end up with a long hold
   opening the RMB menu

Addresses surge-synthesizer#5802
@baconpaul
Copy link
Collaborator

OK so for the main menu position try this

replace this code

if (tag == tag_settingsmenu)
        {
            useDevMenu = true;
            showSettingsMenu(juce::Point<int>{}, control);
            return 1;
        }

with

if (tag == tag_settingsmenu)
        {
            useDevMenu = true;
            showSettingsMenu(control->asJuceComponent()->getTopLeft(), control);
            return 1;
        }

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 4, 2022
1. Add a LongHoldMixin
2. Implement that on slider
3. In touch mode, as a result, you end up with a long hold
   opening the RMB menu

Addresses surge-synthesizer#5802
baconpaul added a commit to baconpaul/surge that referenced this issue Mar 4, 2022
1. Add a LongHoldMixin
2. Implement that on slider
3. In touch mode, as a result, you end up with a long hold
   opening the RMB menu

Addresses surge-synthesizer#5802
baconpaul added a commit that referenced this issue Mar 4, 2022
1. Add a LongHoldMixin
2. Implement that on slider
3. In touch mode, as a result, you end up with a long hold
   opening the RMB menu

Addresses #5802
mkruselj added a commit to mkruselj/surge that referenced this issue Mar 19, 2022
Closes surge-synthesizer#5802 after tweaking it a little more - for some reason long press doesn't activate context menu for EffectChooser.

Also long press context menu is not implemented in OscillatorWaveformDisplay (Alias additive editor has a context menu which would be nice to open via touch too).
mkruselj added a commit that referenced this issue Mar 20, 2022
Closes #5802 after tweaking it a little more - for some reason long press doesn't activate context menu for EffectChooser.

Also long press context menu is not implemented in OscillatorWaveformDisplay (Alias additive editor has a context menu which would be nice to open via touch too).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants