Implement touchscreen long press on sliders #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruselj
changed the title
|
Can be merged, but 2500 ms is too long for a right click. This is actually an adjustable setting on Windows but to get it we'd need to deal with registry, so meh. But reducing it to 750 ms would be nice, before merging. Also the threshold for bailing on long press if a move happens should probably be like 4 px instead of 1. At any rate will need more work down the road (context menus pop up in the wrong place). |
mkruselj
changed the title
baconpaul
force-pushed
the
longpress-5802
branch
from
6c393b7 to
314e5fe
Compare
1. Add a LongHoldMixin 2. Implement that on slider 3. In touch mode, as a result, you end up with a long hold opening the RMB menu Addresses surge-synthesizer#5802
baconpaul
force-pushed
the
longpress-5802
branch
from
314e5fe to
df22249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening the RMB menu
Addresses #5802