Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long press (touch) doesn't open context menu for EffectChooser and OscWaveformDisplay #5980

Closed
mkruselj opened this issue Mar 20, 2022 · 3 comments · Fixed by #5999
Closed
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

Continuation of #5802.

There's widget mixin stuff in EffectChooser.cpp but maybe I badly positioned some of those mixin methods there, or maybe drag and drop fights it somehow. As for OWD, when I tried deriving the widget mixin, it didn't wanna compile saying notifyControlModifierClicked() is undefined etc.

@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Mar 20, 2022
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Mar 20, 2022
@baconpaul
Copy link
Collaborator

Ahh for the oscillator we get to use template specialization. Here's the patch for how to do it.

What this does is it makes onLongHold callback give you the option to call code just for the OWD. It can call any method on the OWD if prefaced with asT()-> as shown.

With this diff plus the method hooks you should be good to go.

Specialize.patch.txt

@baconpaul
Copy link
Collaborator

(That diff calls showCustomEditor which is obviously wrong but shows that it compiles and links)

@mkruselj
Copy link
Collaborator Author

Partially addressed with #5983, however context menu for Alias additive editor opens quite far away from where finger was on long press.

image

mkruselj added a commit to mkruselj/surge that referenced this issue Mar 29, 2022
Used template specialization similarly to OWD, works nicely now!

Closes surge-synthesizer#5980.
mkruselj added a commit that referenced this issue Mar 29, 2022
Used template specialization similarly to OWD, works nicely now!

Closes #5980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants