Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Shift" mode not working in multi-select #4830

Closed
baconpaul opened this issue Aug 11, 2021 · 2 comments · Fixed by #4837
Closed

"Shift" mode not working in multi-select #4830

baconpaul opened this issue Aug 11, 2021 · 2 comments · Fixed by #4837
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

Shift mode doesn't work quite right since we add the model reset onDrag so it double expands

Draw mode i think needs to reset selection overall in lasso mode and de-lasso.
@baconpaul baconpaul added UI Issues related to UI look&feel Modulation Modulation related issues Bug Report Item submitted using the Bug Report template labels Aug 11, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 11, 2021
@mkruselj
Copy link
Collaborator

IMO Draw mode should only draw on the lasso selection and not outside of it.

@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. and removed UI Issues related to UI look&feel labels Aug 11, 2021
@baconpaul
Copy link
Collaborator Author

Oh yeah that’s a good idea

@mkruselj mkruselj changed the title "Shift" ad "Draw" mode not working in multi-select \ "Shift" and "Draw" mode not working in multi-select Aug 12, 2021
@baconpaul baconpaul changed the title "Shift" and "Draw" mode not working in multi-select "Shift" mode not working in multi-select Aug 12, 2021
@baconpaul baconpaul mentioned this issue Aug 12, 2021
Closed
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 12, 2021
@baconpaul
Some small lasso fixes
f5164a9 
1. Shift mode works (but see surge-synthesizer#4835). Closes surge-synthesizer#4830
2. Lasso on Control Points works. Closes surge-synthesizer#4832
@baconpaul baconpaul mentioned this issue Aug 12, 2021
Merged
baconpaul added a commit that referenced this issue Aug 12, 2021
@baconpaul
Some small lasso fixes (#4837)
d56959c 
1. Shift mode works (but see #4835). Closes #4830
2. Lasso on Control Points works. Closes #4832
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Some small lasso fixes baconpaul/surge
2 participants
@mkruselj @baconpaul