Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw mode doesn't work in MSEG #4836

Closed
baconpaul opened this issue Aug 12, 2021 · 1 comment · Fixed by #4842
Closed

Draw mode doesn't work in MSEG #4836

baconpaul opened this issue Aug 12, 2021 · 1 comment · Fixed by #4842
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

It just pans.
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Aug 12, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 12, 2021
@baconpaul
Copy link
Collaborator Author

baconpaul commented Aug 12, 2021 •
edited
Loading

Oh and when we fix this:

IMO Draw mode should only draw on the lasso selection and not outside of it.

is a good idea from @mkruselj from #4830

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Aug 13, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 16, 2021
@baconpaul
Restore MSEG Draw Mode; Implement Draw Mode Lasso
e46be02 
1. Bring the 1.9 version of DrawMode over to JUCE. I had it seems
   just forgotten to do this!
2. Implement the lasso behavior for draw which Evil suggested, which
   is clever and good
3. Handle a few small conseuqences of 1 and 2

Closes surge-synthesizer#4836
@baconpaul baconpaul mentioned this issue Aug 16, 2021
Merged
baconpaul added a commit that referenced this issue Aug 16, 2021
@baconpaul
Restore MSEG Draw Mode; Implement Draw Mode Lasso (#4842)
44e123a 
1. Bring the 1.9 version of DrawMode over to JUCE. I had it seems
   just forgotten to do this!
2. Implement the lasso behavior for draw which Evil suggested, which
   is clever and good
3. Handle a few small conseuqences of 1 and 2

Closes #4836
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Restore MSEG Draw Mode; Implement Draw Mode Lasso baconpaul/surge
2 participants
@mkruselj @baconpaul