Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSEG State restored properly not displayed properly #4835

Closed
baconpaul opened this issue Aug 12, 2021 · 0 comments · Fixed by #4951
Closed

MSEG State restored properly not displayed properly #4835

baconpaul opened this issue Aug 12, 2021 · 0 comments · Fixed by #4951
Labels
Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

Open MSEG Editor
change movement to shift
you get shift
close and open
you get shift
but you see single
because the button doesn't set to the state
i bet
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Aug 12, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 12, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 12, 2021
@baconpaul
Some small lasso fixes
f5164a9 
1. Shift mode works (but see surge-synthesizer#4835). Closes surge-synthesizer#4830
2. Lasso on Control Points works. Closes surge-synthesizer#4832
@baconpaul baconpaul mentioned this issue Aug 12, 2021
Merged
baconpaul added a commit that referenced this issue Aug 12, 2021
@baconpaul
Some small lasso fixes (#4837)
d56959c 
1. Shift mode works (but see #4835). Closes #4830
2. Lasso on Control Points works. Closes #4832
cannero added a commit to cannero/surge that referenced this issue Aug 29, 2021
@cannero
Restore Graphical MSEG State (surge-synthesizer#4835)
a02fcb3 
First the canvas and the controls are created, the reference to each other is set later.
canvas = make; controls = make; canvas->controls = controls; controls->canvas = canvas
So in the first rebuild in controls the canvas member is a nullptr and
the time edit mode value is taken from the state.

The Lfo loop state was not set as integer division was used.

Closes surge-synthesizer#4835
@cannero cannero mentioned this issue Aug 29, 2021
Merged
cannero added a commit to cannero/surge that referenced this issue Aug 29, 2021
@cannero
Restore Graphical MSEG State
be7e7f4 
First the canvas and the controls are created, the reference to each other is set later.
canvas = make; controls = make; canvas->controls = controls; controls->canvas = canvas
So in the first rebuild in controls the canvas member is a nullptr and
the time edit mode value is taken from the state.

The Lfo loop state was not set as integer division was used.

Closes surge-synthesizer#4835
baconpaul pushed a commit that referenced this issue Aug 29, 2021
@cannero
Restore Graphical MSEG State (#4951)
bf0b117 
First the canvas and the controls are created, the reference to each other is set later.
canvas = make; controls = make; canvas->controls = controls; controls->canvas = canvas
So in the first rebuild in controls the canvas member is a nullptr and
the time edit mode value is taken from the state.

The Lfo loop state was not set as integer division was used.

Closes #4835
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Restore Graphical MSEG State cannero/surge
1 participant
@baconpaul