Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABC-order variant analysis linting config #2219

Merged
merged 1 commit into from
Sep 27, 2022
Merged

ABC-order variant analysis linting config #2219

merged 1 commit into from
Sep 27, 2022

Conversation

dfarrell07
Copy link
Member

This job was called vulnerability variant analysis during most of
development. It should have been reordered when the name was shortened.

Relates-to: submariner-io/submariner#1970
Signed-off-by: Daniel Farrell [email protected]

@dfarrell07 dfarrell07 requested a review from mkolesnik as a code owner August 30, 2022 19:43
@dfarrell07 dfarrell07 self-assigned this Aug 30, 2022
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2219/dfarrell07/abc_linting
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@dfarrell07 dfarrell07 mentioned this pull request Aug 30, 2022
Closed
@tpantelis
Copy link
Contributor

It looks like the System Tests were broken by submariner-io/shipyard#924 @mkolesnik

@dfarrell07
Copy link
Member Author

It looks like the System Tests were broken by submariner-io/shipyard#924 @mkolesnik

Cross-linking my comment about adding System Tests to the Consuming Projects tests.

@stale
Copy link

stale bot commented Sep 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 20, 2022
@dfarrell07 dfarrell07 force-pushed the abc_linting branch 2 times, most recently from 5420d1b to 8f08720 Compare September 26, 2022 20:50
@stale stale bot removed the wontfix This will not be worked on label Sep 26, 2022
@dfarrell07
ABC-order variant analysis linting config
99d4dfc 
This job was called vulnerability variant analysis during most of
development. It should have been reordered when the name was shortened.

https://codeql.github.com/docs/codeql-overview/about-codeql/

Relates-to: submariner-io/submariner#1970
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this pull request Sep 27, 2022
Merged
@dfarrell07
Copy link
Member Author

The rebase here keeps getting broken by updates to the codeql-action GHA SHA.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Sep 27, 2022
@skitt skitt enabled auto-merge (rebase) September 27, 2022 13:36
@skitt skitt merged commit 7b613d4 into submariner-io:devel Sep 27, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2219/dfarrell07/abc_linting]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@skitt skitt skitt approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees

@dfarrell07 dfarrell07

Labels
automation blocked-on-rereview ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfarrell07 @submariner-bot @tpantelis @skitt