Use image overrides when deploying #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr924/mkolesnik/join-overrides |
mkolesnik
changed the title
Use image overrides, based on `$PRELOAD_IMAGES`, for determining which exact images to override. This will allow us to test just the images that we want to test, and use the default images elsewhere. A dev can still specify specific images, e.g. `make deploy PRELOAD_IMAGES='submariner-gateway submariner-operator'` Signed-off-by: Mike Kolesnik <[email protected]>
Similarly to using image overrides in operator based deployments - use image overrides, based on `$PRELOAD_IMAGES`, for determining which exact images to override. Signed-off-by: Mike Kolesnik <[email protected]>
Each project should determine it's own images to preload. Needed images are still preloaded when using specific deployments, such as `globalnet` or `lighthouse`. Signed-off-by: Mike Kolesnik <[email protected]>
mkolesnik
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
skitt
approved these changes
Aug 31, 2022
tpantelis
approved these changes
Aug 31, 2022
|
🤖 Closed branches: [z_pr924/mkolesnik/join-overrides] |
|
This seems to have broken the System Tests workflow in the Operator repo. To prevent such issues in the future, maybe we should add those tests to the Consuming Projects tests here (maybe under the |
Yes that might be wise, anyhow I'll fix the tests |
|
Fix for operator system tests - submariner-io/submariner-operator#2222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use image overrides, based on
$PRELOAD_IMAGES, for determining whichexact images to override.
This will allow us to test just the images that we want to test, and use
the default images elsewhere.
A dev can still specify specific images, e.g.
make deploy PRELOAD_IMAGES='submariner-gateway submariner-operator'Resolves: #915
Signed-off-by: Mike Kolesnik [email protected]