Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABC-order variant analysis linting config #2219

Merged
merged 1 commit into from
Sep 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,24 @@ jobs:
- name: Run shellcheck
run: make shellcheck

variant-analysis:
name: Variant Analysis
dfarrell07 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@86f3159a697a097a813ad9bfa0002412d97690a4
with:
languages: go
- name: Build code, creating CodeQL database
run: make build
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@86f3159a697a097a813ad9bfa0002412d97690a4
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

vulnerability-scan:
name: Vulnerability Scanning
runs-on: ubuntu-latest
Expand All @@ -147,24 +165,6 @@ jobs:
with:
sarif_file: ${{ steps.scan.outputs.sarif }}

variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@86f3159a697a097a813ad9bfa0002412d97690a4
with:
languages: go
- name: Build code, creating CodeQL database
run: make build
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@86f3159a697a097a813ad9bfa0002412d97690a4
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

yaml-lint:
name: YAML
runs-on: ubuntu-latest
Expand Down
40 changes: 20 additions & 20 deletions .github/workflows/report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,26 @@ on:
permissions: {}

jobs:
variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
permissions:
security-events: write
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@86f3159a697a097a813ad9bfa0002412d97690a4
with:
languages: go
- name: Build code, creating CodeQL database
run: make build
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@86f3159a697a097a813ad9bfa0002412d97690a4
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

vulnerability-scan:
name: Vulnerability Scanning
if: github.repository_owner == 'submariner-io'
Expand All @@ -31,23 +51,3 @@ jobs:
uses: github/codeql-action/upload-sarif@86f3159a697a097a813ad9bfa0002412d97690a4
with:
sarif_file: ${{ steps.scan.outputs.sarif }}

variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
permissions:
security-events: write
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@86f3159a697a097a813ad9bfa0002412d97690a4
with:
languages: go
- name: Build code, creating CodeQL database
run: make build
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@86f3159a697a097a813ad9bfa0002412d97690a4
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif