Bump golangci-lint to 1.50.1

[skitt]

Changes since 1.47.3:

• https://github.com/golangci/golangci-lint/releases/tag/v1.48.0
• https://github.com/golangci/golangci-lint/releases/tag/v1.49.0
• https://github.com/golangci/golangci-lint/releases/tag/v1.50.0
• https://github.com/golangci/golangci-lint/releases/tag/v1.50.1

Depends on submariner-io/subctl#375
Depends on submariner-io/admiral#461
Depends on submariner-io/cloud-prepare#465
Depends on submariner-io/lighthouse#960
Depends on submariner-io/subctl#379
Depends on submariner-io/submariner#2127
Depends on submariner-io/submariner-operator#2353
Depends on submariner-io/submariner#2147

Signed-off-by: Stephen Kitt [email protected]

[submariner-bot]

🤖 Created branch: z_pr993/skitt/golangci-lint-1.50.0

[dfarrell07]

Testing enabling the new linters from these versions here: dfarrell07#48

[skitt]

We should postpone this until after rc0, there’s quite a lot of work involved.

[dfarrell07]

Maybe I can send some of the simpler fixes before the RC so we don't have to backport them? A lot of the issues seem related to spacing of nolint directives.

[skitt]

Maybe I can send some of the simpler fixes before the RC so we don't have to backport them? A lot of the issues seem related to spacing of nolint directives.

I’ve scripted that one ;-).

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[skitt]

@dfarrell07, @tpantelis, this is ready to go.

[github-actions]

This PR/issue depends on:

• Replace io/ioutil with os or io package subctl#375
• Prepare for golangci-lint 1.50.1 admiral#461
• Drop the leading spaces before the ASL URL cloud-prepare#465
• Prepare for golangci-lint 1.50.1 lighthouse#960
• Prepare for golangci-lint 1.50.1 subctl#379
• Prepare for golangci-lint 1.50.1 submariner#2127
• Prepare for golangci-lint 1.50.1 submariner-operator#2353
• More gofumpt with Go 1.19 submariner#2147
  By Dependent Issues (🤖). Happy coding!

[submariner-bot]

🤖 Closed branches: [z_pr993/skitt/golangci-lint-1.50.0]