Prepare for golangci-lint 1.50.1 #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2127/skitt/golangci-lint-1.50.1 |
skitt
force-pushed
the
golangci-lint-1.50.1
branch
from
437ced7 to
f7fbbf8
Compare
This causes conflicts with gci in some cases. Signed-off-by: Stephen Kitt <[email protected]>
varcheck, deadcode, and structcheck are deprecated since 1.49.0. Signed-off-by: Stephen Kitt <[email protected]>
Signed-off-by: Stephen Kitt <[email protected]>
contextcheck complains about the sequence fatal -> SetGatewayStatusError -> syncGatewayStatusSafe -> cleanupStaleGatewayEntries (the last uses a context, and there is a context in the becameLeader function) but we don't care. We can't //nolint this in main.go because of the varying behaviour in the linter between golangci-lint 1.47.3 and 1.50.1, so ignore contextcheck entirely for main.go for the time being. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
golangci-lint-1.50.1
branch
from
f7fbbf8 to
5a4bc62
Compare
dfarrell07
approved these changes
Nov 15, 2022
tpantelis
approved these changes
Nov 15, 2022
|
🤖 Closed branches: [z_pr2127/skitt/golangci-lint-1.50.1] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.