Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for golangci-lint 1.50.1 #960

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

skitt
Copy link
Member

@skitt skitt commented Nov 14, 2022

See individual commits for details.

This causes conflicts with gci in some cases.

Signed-off-by: Stephen Kitt <[email protected]>
varcheck, deadcode, and structcheck are deprecated since 1.49.0.

Signed-off-by: Stephen Kitt <[email protected]>
This is enforced by newer releases of golangci-lint.

Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr960/skitt/golangci-lint-1.50.1
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@dfarrell07 dfarrell07 enabled auto-merge (rebase) November 15, 2022 12:20
@tpantelis tpantelis added the ready-to-test When a PR is ready for full E2E testing label Nov 15, 2022
@skitt skitt changed the title Prepare for golangci-lint 1.50.1 maintenance Prepare for golangci-lint 1.50.1 Nov 15, 2022
@dfarrell07 dfarrell07 merged commit 9fdff05 into submariner-io:devel Nov 15, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr960/skitt/golangci-lint-1.50.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-handled ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants