Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1762

Merged
merged 28 commits into from
Oct 5, 2022
Merged

Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1762

merged 28 commits into from
Oct 5, 2022

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
Part 3/3 of fluid mixing model. In this part, Heat capacities and mass diffusivity based on species mass fractions have been added.

I am still working in checking the Non-dimensional case, I expect to complete it during this week.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
It is the continuation of the previous pull request of mixing density #1620 and #1690.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

pcarruscag
pcarruscag reviewed Sep 15, 2022
View reviewed changes
Common/src/CConfig.cpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CConstantDiffusivity.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CConstantSchmidt.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CConstantSchmidt.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp Outdated Show resolved Hide resolved
@bigfooted
Copy link
Contributor

The naming "passive scalar' is inappropriate now. Maybe change this to 'species transport' everywhere.
Looks like you can safely do a 'search and replace all' on "passive scalar" and "PASSIVE_SCALAR"

@bigfooted
Copy link
Contributor

@Cristopher-Morales any things left for this PR? If PASSIVE_SCALAR is changed to SPECIES_TRANSPORT, and if you have confirmed that the nondimensionalization works correctly, then from my side it will be good to go. You can put a tutorial and regression test for the adjoint optimization in the next PR.

pcarruscag
pcarruscag reviewed Oct 1, 2022
View reviewed changes
SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CFluidModel.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp Outdated Show resolved Hide resolved
@pcarruscag
Copy link
Member

Btw, once you think a PR is ready for another review round, leave a message or remove [WIP] from the title.

pcarruscag
pcarruscag reviewed Oct 3, 2022
View reviewed changes
SU2_CFD/include/fluid/CConstantSchmidt.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp Outdated Show resolved Hide resolved
TestCases/parallel_regression.py Show resolved Hide resolved
...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg Outdated Show resolved Hide resolved
Common/include/CConfig.hpp Outdated Show resolved Hide resolved
Common/include/CConfig.hpp Outdated Show resolved Hide resolved
Common/include/CConfig.hpp Outdated Show resolved Hide resolved
@pcarruscag pcarruscag changed the title [WIP] Composition-dependent heat capacities and mass diffusivity models for incompresible flows Composition-dependent heat capacities and mass diffusivity models for incompresible flows Oct 4, 2022
pcarruscag
pcarruscag approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Cristopher-Morales
Copy link
Contributor Author

I have added a pull request for the Tutorials in order to change PASSIVE_SCALAR to SPECIES_TRANSPORT #27. Please let me know if it is ok to do it.

@pcarruscag
Copy link
Member

Sure, is there anything on the website tutorials that needs to be updated?

@Cristopher-Morales
Copy link
Contributor Author

Sure, is there anything on the website tutorials that needs to be updated?
Hi, yes in the tutorial created by Tobias the option PASSIVE_SCALAR must be changed to SPECIES_TRANSPORT. Should I do a pull request for modifying it?

@pcarruscag
Copy link
Member

Of course

@Cristopher-Morales Cristopher-Morales merged commit 399b73b into develop Oct 5, 2022
@Cristopher-Morales Cristopher-Morales deleted the feature_mass_diffusivity branch October 5, 2022 15:04
@lkusch lkusch mentioned this pull request Oct 7, 2022
Merged
2 tasks
@Cristopher-Morales Cristopher-Morales mentioned this pull request Oct 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigfooted bigfooted bigfooted left review comments

@pcarruscag pcarruscag pcarruscag approved these changes

Assignees
No one assigned
Labels
changelog:feature PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cristopher-Morales @bigfooted @pcarruscag