Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Schmidt diffusivity model and adding option of Constant Lewis number #1787

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

Fixing the CONSTANT_SCHMIDT diffusivity model and removing the Constant_SchimdtRANS class because it is not needed. Additionally, the class CUnityLewisDiffusivity has been modified to CConstantLewisDiffusivity in order to allow users to use constant Lewis number for each species but different to one, which is the assumption of Unity_Lewis. 
The option UNITY_LEWIS is still available in order to allow users to use that option. New option, CONSTANT_LEWIS, is added for the purpose aforementioned.
I can add a test case for the additional option if it is needed.

Related Work

This pull request is related to #1762

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X ] I am submitting my contribution to the develop branch.
  • [X ] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants