-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition-dependent viscosity and thermal conductivity models for incompresible flows #1690
Conversation
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
… into feature_mixturedensity
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Thank you so much @pcarruscag for your feedback. there is one thing left, it is about the residuals of the test case (species2_primitiveVenturi_mixingmodel.cfg) that I added in the previous pull request, they have changed exceeding in some outputs the tolerance 0.00001 with respect to the values stored in the parallel_regression.py, however the test case converges very well, so could it be possible to modify the values stored in that test case in order to not have this discrepancy between values stored and computed? Thank you so much in advance!! |
Have you run that case to convergence before and after and compared the outputs it is computing? If it converges to the same values it's fine. |
@@ -273,6 +273,7 @@ void CIncEulerSolver::SetNondimensionalization(CConfig *config, unsigned short i | |||
|
|||
config->SetTemperature_Ref(1.0); | |||
config->SetViscosity_Ref(1.0); | |||
config->SetConductivity_Ref(1.0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not needed at the moment, if you want to add it please do so also for the other solvers.
To clarify on my comment, do composition-dependent properties work with non-dimensional simulations? or not?
If they don't and the fix is not easy we need to throw an error.
If they do we need a regression test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the explanation. I will check whether it works for Non-dimensional simulations.
This reverts commit 6e5c4c2.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Part 2/3 of fluid mixing model. In this part, viscosity, thermal conductivity and other properties based on species mass fractions have been added.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
It is the continuation of the previous pull request of mixing density #1620.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.