Put a Deprecated notice on TotalCount
#1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still have `TotalCount` in a list's meta information. So as to not make a breaking change, I'm going to leave it in, but add a `Deprecated` notice on it. I also reword the comment because the note to "see tests" is no longer accurate (we don't have a `total_count` sample in the suite anymore). Replaces #1213.
brandur-stripe
force-pushed
the
brandur-total-count-deprecated
branch
from
78012ed to
e1a8cc4
Compare
|
Thank you very much @brandur-stripe , I supposed my comment wasn't accurate but I wanted to lead the initiative with a little change :) Again thank you for taking the time :) |
No worries at all, and thanks again! |
|
(This one's quite small and comment-only, so just going to self-review and merge.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have
TotalCountin a list's meta information. So as to notmake a breaking change, I'm going to leave it in, but add a
Deprecatednotice on it.
I also reword the comment because the note to "see tests" is no longer
accurate (we don't have a
total_countsample in the suite anymore).Replaces #1213.