Add the deprecation note to the total_count field #1213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
total_count property is not available anymore becuse it was removed in May 26th 2020
|
|
|
Thanks @ethervoid! I think it's a good idea to clean this up, but you've changed the sentence so that its entirety doesn't quite make sense:
Going to close this out and push a tweak on a different PR. |
brandur-stripe
pushed a commit
that referenced
this pull request
Oct 21, 2020
We still have `TotalCount` in a list's meta information. So as to not make a breaking change, I'm going to leave it in, but add a `Deprecated` notice on it. I also reword the comment because the note to "see tests" is no longer accurate (we don't have a `total_count` sample in the suite anymore). Replaces #1213.
|
Opened #1214. |
brandur-stripe
pushed a commit
that referenced
this pull request
Oct 21, 2020
We still have `TotalCount` in a list's meta information. So as to not make a breaking change, I'm going to leave it in, but add a `Deprecated` notice on it. I also reword the comment because the note to "see tests" is no longer accurate (we don't have a `total_count` sample in the suite anymore). Replaces #1213.
brandur-stripe
added a commit
that referenced
this pull request
Oct 21, 2020
We still have `TotalCount` in a list's meta information. So as to not make a breaking change, I'm going to leave it in, but add a `Deprecated` notice on it. I also reword the comment because the note to "see tests" is no longer accurate (we don't have a `total_count` sample in the suite anymore). Replaces #1213. Co-authored-by: Brandur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
total_count property is not available anymore becuse it was removed in May 26th 2020