Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a Deprecated notice on TotalCount #1214

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Put a Deprecated notice on TotalCount #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,14 @@ type ListContainer interface {
// total_count include option is passed in (see tests for example).
type ListMeta struct {
HasMore bool `json:"has_more"`
TotalCount uint32 `json:"total_count"`
URL string `json:"url"`

// TotalCount is the total number of objects in the collection (beyond just
// on the current page). This is not returned in most list calls.
//
// Deprecated: TotalCount is only included in some legacy situations and
// not generally available anymore.
TotalCount uint32 `json:"total_count"`
}

// GetListMeta returns a ListMeta struct (itself). It exists because any
Expand Down