Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quest] How power line is attached on this support? #5382

Merged
merged 11 commits into from
Nov 14, 2024
Merged

[Quest] How power line is attached on this support? #5382

merged 11 commits into from
Nov 14, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Nov 21, 2023 •
edited
Loading

Fixes #4825

Todo:

  • Improve translations (en and fr)
  • Add graphics (photos or SVG)

@matkoniecz
Copy link
Member

I still have serious doubts about value of collecting this data (like for power=pole materials) but per #4825 (comment) westnordost seems convinced.

qugebert
qugebert reviewed Nov 22, 2023
View reviewed changes
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachment.kt
"""
override val changesetComment = "Specify line_attachment power support"
override val wikiLink = "Key:line_attachment"
override val icon = R.drawable.ic_quest_power
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quest should get a own icon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?
SC has similars quests with same the icon.
Do you have a better idea?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because all quests have each a unique icon. But right now, I am unable to come up with a good idea for an icon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a circle/disk/line at the bottom (and/or top) of the lightning bolt, making contact?

@Jean-BaptisteC Jean-BaptisteC force-pushed the line_attachment branch 2 times, most recently from 8d48ce3 to e1f8618 Compare January 28, 2024 19:55
@Jean-BaptisteC
Copy link
Contributor Author

@flacombe any news?

@FloEdelmann FloEdelmann added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label May 13, 2024
@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented May 17, 2024 •
edited
Loading

I want finish this PR
These graphics is enough recognizable?

@mnalis
Copy link
Member

mnalis commented May 22, 2024

These graphics is enough recognizable?

At desktop they do seem recognizable to me, but I'm not sure how they'd look scaled down to just a small part of (already small) mobile phone screen. Although looking at thumbnails at https://wiki.openstreetmap.org/wiki/Key:line_attachment they might probably be fine.

@westnordost
Copy link
Member

westnordost commented Jun 15, 2024 •
edited
Loading

These graphics is enough recognizable?

Theoretically yes, I think, after all the picture could be cropped a little to focus on what's important. (But need to try it out.)
However, the minimum size is 384x384 (that's for 3x display density displays, the thumbnail would have a size of 128x128 pixels on a desktop) and the pictures are smaller than that.

Also, it would be preferable if anything but the supports was about the same on the pictures, i.e. similar sky background, similar perspective.

@Jean-BaptisteC
Copy link
Contributor Author

I have found better examples with good quality:

I continue to search an example for line_attachment=pin

@flacombe any suggestions?

@Jean-BaptisteC
Copy link
Contributor Author

I have take a new pictures during my trip in Canada

Pin

Anchor

Someone can help me to finish this PR?

@Jean-BaptisteC
Copy link
Contributor Author

@westnordost do you think is enough recognizable?

@flacombe
Copy link

Hello @Jean-BaptisteC and thank you for pictures.

To me it's all good and recognizable.
I'm not the most puzzled by such pictures though. How do others feel about them?

@westnordost
Copy link
Member

The difference is definitely recognizable. The first are some UFOs, the other are some springs. It's also nice that everything else about the pics is similar (the sky, the kind of pole), it highlights the differences.

@Jean-BaptisteC
Copy link
Contributor Author

The PR is ready, I have added pictures from my personal albums, I have only added photos about power pole because I think the anchor is more easy to understand on pole than on big tower (on a too tiny photos)

@Jean-BaptisteC Jean-BaptisteC marked this pull request as ready for review October 21, 2024 17:42
westnordost
westnordost reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In /app/src/main/res there is a file named authors.txt. Could you please add the source, license and author in the form as they are supplied for the other graphics used within this app?

...rc/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachmentForm.kt Outdated Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachment.kt
"""
override val changesetComment = "Specify line_attachment power support"
override val wikiLink = "Key:line_attachment"
override val icon = R.drawable.ic_quest_power
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because all quests have each a unique icon. But right now, I am unable to come up with a good idea for an icon.

app/src/main/java/de/westnordost/streetcomplete/quests/power_attachment/AddPowerAttachment.kt Show resolved Hide resolved
@westnordost
Copy link
Member

Since the photos are (in part) from your personal albums, you can choose a license by yourself, anything between PD, CC-0, CC-BY and CC-BY-SA would be fine. It would be convenient if the original photos were available somewhere, e.g. in Wikimedia commons or in the OpenStreetMap Wiki.

Finally, one more note: I noticed that one of the three pictures shows a power pole that is more zoomed out. It would be best if they had all the same zoom on the line attachment. The kind of line attachment is better to see, then.

@Jean-BaptisteC
Copy link
Contributor Author

I have added photos on wikimedia and I have update authors.txt.
I have tried to resize suspension photo, but I didn't find the right solution to resize without too much crop top of the pole.

@westnordost
Copy link
Member

https://commons.wikimedia.org/wiki/File:Power_pole_anchor.jpg is a different picture than the one you use in StreetComplete.

I have tried to resize suspension photo, but I didn't find the right solution to resize without too much crop top of the pole.

Hm? Why not like this?

imagen

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented Oct 23, 2024 •
edited
Loading

Photo is fixed on wikimedia :)
I have tried this solution but with hdpi and mdpi resolution, the sides of pole is too much cutted.

FIY, to generates drawables, I have reduced the quality of photos, down size resolution from 50%, generates first drawables, down size resolution from 25%, ...
I don't know if it's the best solution 🤔, I'm not an expert of photos editing 🙂

@westnordost
Copy link
Member

I don't get it. Sides of the pole too much cutted? Can you post a picture? Maybe then I understand what you mean.

I create the drawables by, in GIMP:

  1. crop the original image to the square I need
  2. resize the image to 384x384, save to xxhdpi, undo, resize to 256x256, save to xhdpi, undo, etc...

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented Oct 23, 2024 •
edited
Loading

Files updated
Screenshots in first comment updated
Thanks for the tips, my solution is very too much complex 😅

@westnordost
Copy link
Member

Alright, note also this:

https://commons.wikimedia.org/wiki/File:Power_pole_anchor.jpg is a different picture than the one you use in StreetComplete.

@Jean-BaptisteC
Copy link
Contributor Author

Already fixed on wikimedia commons 🙂
Ready to merge?

@westnordost westnordost merged commit dd4514b into streetcomplete:master Nov 14, 2024
@Jean-BaptisteC Jean-BaptisteC deleted the line_attachment branch November 14, 2024 06:04
@mnalis
Copy link
Member

mnalis commented Dec 6, 2024

On small local power=pole nodes, I get lot of situations like this: https://www.openstreetmap.org/note/4544696 which I am unsure how to map?

253048

@Jean-BaptisteC
Copy link
Contributor Author

Select Fixed horizontally, these cases is not the most of case in OSM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qugebert qugebert qugebert left review comments

@FloEdelmann FloEdelmann FloEdelmann left review comments

@goldfndr goldfndr goldfndr left review comments

@westnordost westnordost westnordost approved these changes

Assignees
No one assigned
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line attachments on power poles/towers
8 participants
@Jean-BaptisteC @matkoniecz @mnalis @westnordost @flacombe @goldfndr @FloEdelmann @qugebert