network: unit test for TrackerConnector #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
approved these changes
Oct 15, 2021
timoxley
added a commit
that referenced
this pull request
Oct 15, 2021
* main: fix(network): Node: rm unused constructor opts network: unit test for TrackerConnector (#250) network [NET-264]: rework node propagation logic (#211) broker: remove Todo type (#248) Update plugins.md Update README.md Update README.md DEVOP-102: run broker Docker build in self hosted runner (#249) network: refactor inbound/outboundNodes to neighbors (#247)
timoxley
pushed a commit
that referenced
this pull request
Oct 19, 2021
- Add efficient method to loop thru streams `StreamManager#getStreamsIterable` - Make `TrackerConnector` take functions in constructor as opposed to classes - Unit test for `TrackerConnector`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamManager#getStreamsIterableTrackerConnectortake functions in constructor as opposed to classesTrackerConnector