-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: refactor inbound/outboundNodes to neighbors #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harbu
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
Looks like browser tests are not compatible with jest-extended
atm?
timoxley
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timoxley
added a commit
that referenced
this pull request
Oct 15, 2021
* main: fix(network): Node: rm unused constructor opts network: unit test for TrackerConnector (#250) network [NET-264]: rework node propagation logic (#211) broker: remove Todo type (#248) Update plugins.md Update README.md Update README.md DEVOP-102: run broker Docker build in self hosted runner (#249) network: refactor inbound/outboundNodes to neighbors (#247)
timoxley
pushed a commit
that referenced
this pull request
Oct 19, 2021
Simplify status message content and topology handling: - Previously each status message contained inboundNodes and outboundNodes for a stream. - Those two arrays had exactly same content - Now we use one array, called neighbors There is also a backwards compatibility handling Tracker.ts, which enables the tracker to receive the statuses in the old format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify status message content and topology handling:
inboundNodes
andoutboundNodes
for a stream.neighbors
There is also a backwards compatibility handling
Tracker.ts
, which enables the tracker to receive the statuses in the old format.