Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: refactor inbound/outboundNodes to neighbors #247

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Conversation

teogeb
Copy link
Contributor

@teogeb teogeb commented Oct 13, 2021

Simplify status message content and topology handling:

  • Previously each status message contained inboundNodes and outboundNodes for a stream.
  • Those two arrays had exactly same content
  • Now we use one array, called neighbors

There is also a backwards compatibility handling Tracker.ts, which enables the tracker to receive the statuses in the old format.

@teogeb teogeb requested a review from harbu October 13, 2021 12:20
@github-actions github-actions bot added the network Related to Network Package label Oct 13, 2021
Copy link
Contributor

@harbu harbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

Looks like browser tests are not compatible with jest-extended atm?

Copy link
Contributor

@timoxley timoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only gripe is neighbours vs neighbors:

image

@teogeb teogeb merged commit b9238a1 into main Oct 13, 2021
@teogeb teogeb deleted the status-neighbors branch October 13, 2021 20:43
timoxley added a commit that referenced this pull request Oct 15, 2021
* main:
  fix(network): Node: rm unused constructor opts
  network: unit test for TrackerConnector (#250)
  network [NET-264]: rework node propagation logic (#211)
  broker: remove Todo type (#248)
  Update plugins.md
  Update README.md
  Update README.md
  DEVOP-102: run broker Docker build in self hosted runner (#249)
  network: refactor inbound/outboundNodes to neighbors (#247)
timoxley pushed a commit that referenced this pull request Oct 19, 2021
Simplify status message content and topology handling:

- Previously each status message contained inboundNodes and outboundNodes for a stream.
- Those two arrays had exactly same content
- Now we use one array, called neighbors

There is also a backwards compatibility handling Tracker.ts, which enables the tracker to receive the statuses in the old format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Related to Network Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants