Source-loader: Warn if applied to non-stories file #8773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/l2lrut76i |
shilman
changed the title
shilman
changed the title
shilman
requested changes
Nov 9, 2019
There was a problem hiding this comment.
Thanks @donaldpipowitch, this is great! Mind updating this to use @storybook/node-logger instead?
shilman
added
the
patch:yes
|
@shilman sure :) Thank you for the fast review. |
@shilman did you meant |
shilman
approved these changes
Nov 10, 2019
shilman
requested changes
Nov 10, 2019
|
@shilman Fixed 👍 |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Dec 2, 2019
Source-loader: Warn if applied to non-stories file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8294
What I did
I added a warning for people like me who misconfigured the
@storybook/source-loader. If I understand correctly, it should only be used for files containing stories. In my webpack config it was applied to all source code files.How to test
Checkout my PR,
cd lib/source-loader && yarn prepare && yarn link. After that$ git clone [email protected]:donaldpipowitch/storybook-bug-demo-source-loader-context-null.git && cd storybook-bug-demo-source-loader-context-null && yarn && yarn link "@storybook/source-loader" && yarn storybook. You should see the warning.