Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-loader: Warn if applied to non-stories file #8773

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Source-loader: Warn if applied to non-stories file #8773

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01ca395
check context in source-loader
donaldpipowitch Nov 9, 2019
e4ab56d
updated logging based on feedback
donaldpipowitch Nov 10, 2019
0e80a46
fixed logger
donaldpipowitch Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/source-loader/src/client/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ function sendEvent(
prefix,
idsToFrameworks
) {
if (!context || !context.id || !context.kind || !context.story) {
console.warn(
'@storybook/source-loader was applied to a file which does not contain a story. Please check your webpack configuration and make sure to apply @storybook/source-loader only to files containg stories. Related file:'
);
console.warn(source);
return;
}

const channel = addons.getChannel();
const currentLocation = getLocation(context, locationsMap);

Expand Down