Build: Add vite-react to e2e tests

[yannbf]

Issue: N/A

What I did

Added vite builder example to E2E, so we guarantee there are no unintended breaking changes 👌

cc @IanVS

How to test

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4e00ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[IanVS]

This is great, seems easy! But, is it actually running in CI? I see:

Will run E2E tests for:react, vue3

and don't see vite actually running.

[yannbf]

The e2e tests under e2e-tests-core happen in parallel so you might have checked the first batch of tests. You can find the one with vite here but it's unfortunately failing with no helpful message. I'll have to check this further!

[IanVS]

@yann, it seems the error is occurring because @storybook/builder-vite is not in https://github.com/storybookjs/storybook/blob/43be92e13b75f91b99372f0707043739ca5951b9/lib/cli/src/versions.ts. And furthermore, when running yarn local-registry --port 6000 --open --publish, then yarn npm info @storybook/builder-vite --fields version --json errors out because it's looking for a locally published package.

Not Found - GET http://localhost:6000/@storybook%2fbuilder-vite - no such package available

🤦

[IanVS]

I've pushed up a fix as a separate PR (#17897)

Maybe you could also add this, so that the interactions are tested?

// addon-interactions.spec.ts

onlyOn('vite_react', () => {
    it('should have interactions', test);
  });

[yannbf]

I've pushed up a fix as a separate PR (#17897)

Maybe you could also add this, so that the interactions are tested?

// addon-interactions.spec.ts

onlyOn('vite_react', () => {
    it('should have interactions', test);
  });

You're the best! I updated this branch with latest next and included vite_react to the E2E test. 🤞

[shilman]

LGTM