Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add vite-react to e2e tests #17871

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Build: Add vite-react to e2e tests #17871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56864b7
add vite-react to e2e tests
yannbf Apr 4, 2022
f4e00ff
add vite to interaction e2e tests
yannbf Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ jobs:
name: Run E2E (core) tests
# Do not test CRA here because it's done in PnP part
# TODO: Remove `web_components_typescript` as soon as Lit 2 stable is released
command: yarn test:e2e-framework vue3 angular130 angular13 angular12 angular11 web_components_typescript web_components_lit2 react
command: yarn test:e2e-framework vue3 angular130 angular13 angular12 angular11 web_components_typescript web_components_lit2 react vite_react
no_output_timeout: 5m
- store_artifacts:
path: /tmp/cypress-record
Expand Down
4 changes: 4 additions & 0 deletions cypress/generated/addon-interactions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,8 @@ describe('addon-interactions', () => {
onlyOn('react', () => {
it('should have interactions', test);
});

onlyOn('vite_react', () => {
it('should have interactions', test);
});
});
7 changes: 7 additions & 0 deletions lib/cli/src/repro-generators/configs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ export const webpack_react: Parameters = {
generator: fromDeps('react', 'react-dom', 'webpack@webpack-4'),
};

export const vite_react: Parameters = {
framework: 'react',
name: 'vite_react',
version: 'latest',
generator: 'npx -p create-vite@{{version}} create-vite {{appName}} --template react-ts',
};

export const react_in_yarn_workspace: Parameters = {
framework: 'react',
name: 'react_in_yarn_workspace',
Expand Down