Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude @storybook/builder-vite from verdaccio #17897

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 6, 2022

Issue:

What I did

I believe this will fix the failing test in #17871, which was having problems because it was trying to get the version information of @storybook/builder-vite from the local verdaccio server instead of npm.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@IanVS IanVS added the maintenance User-facing maintenance tasks label Apr 6, 2022
@IanVS IanVS requested a review from shilman April 6, 2022 02:25
@nx-cloud
Copy link

nx-cloud bot commented Apr 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1417b4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@IanVS IanVS mentioned this pull request Apr 6, 2022
3 tasks
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman closed this Apr 6, 2022
@shilman shilman reopened this Apr 6, 2022
@shilman shilman merged commit d5338e9 into next Apr 6, 2022
@shilman shilman deleted the exclude-builder-vite-verdaccio branch April 6, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants