-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Pre-bundle @storybook/theming
to avoid emotion11 conflicts
#17000
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit be09c8f. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit 603908d. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
5cd383b
to
76f7f1b
Compare
69a7dd1
to
99bfb63
Compare
# Conflicts: # lib/theming/package.json # yarn.lock
…he tmp directory when done add ts3.4 setup to bundling script
# Conflicts: # lib/theming/package.json # yarn.lock
@storybook/theming
to avoid emotion11 conflicts
Now using alpha storybook for emotion 11 support, which is required for MUI See mui/material-ui#24282 and storybookjs/storybook#17000
Now using alpha storybook for emotion 11 support, which is required for MUI See mui/material-ui#24282 and storybookjs/storybook#17000
Now using alpha storybook for emotion 11 support, which is required for MUI See mui/material-ui#24282 and storybookjs/storybook#17000
Now using alpha storybook for emotion 11 support, which is required for MUI See mui/material-ui#24282 and storybookjs/storybook#17000
This mean that the
|
@robinmetral already done in the 7.0 branch |
Issue: #16716 #13145 #13114
introduce pre-bundle script as an alternative to prepare script.
pre-bundling means we'll:
we actually create the bundle 3 times (CJS, ESM, modern)
We can specify our source-code entry-point in our package's package.json file:
And we can specify which dependencies we'd like to NOT be bundled (will apply to both the runtime bundles and type-definitions) by adding those modules to the
dependencies
andpeerDependencies
properties inpackage.json
To use the prebundle script instead of the prepare script:
You may need to install
ts-node
in the package for this to work.TODO:
dist/ts3.4
again.yarn dev