Theming: Re-export correct bundled file #17956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This might fix #17916.
When trying to use
@storybook/theming
with the latest storybook 6.5.0-alpha.62, in the mealdrop repo, I got errors like:What I did
I found that
@storybook/theming/create.js
tries to re-export from./dist/esm/create
, which no longer exists (after #17000, I think). So, I changed the path to just./dist/esm
, and found that this indeed solves my error.cc/ @yannbf, since it looks like you might have hit this as well, in yannbf/mealdrop@c973a55, since you renamed the manager file, presumably to avoid the problem.
How to test