Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: Re-export correct bundled file #17956

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 13, 2022

Issue:

This might fix #17916.

When trying to use @storybook/theming with the latest storybook 6.5.0-alpha.62, in the mealdrop repo, I got errors like:

ERROR in ./node_modules/@storybook/theming/create.js 2:0-34
Module not found: Error: Can't resolve './dist/esm/create' in '/Users/ianvs/code/storybook-benchmarks/mealdrop/node_modules/@storybook/theming'
resolve './dist/esm/create' in '/Users/ianvs/code/storybook-benchmarks/mealdrop/node_modules/@storybook/theming'

What I did

I found that @storybook/theming/create.js tries to re-export from ./dist/esm/create, which no longer exists (after #17000, I think). So, I changed the path to just ./dist/esm, and found that this indeed solves my error.

cc/ @yannbf, since it looks like you might have hit this as well, in yannbf/mealdrop@c973a55, since you renamed the manager file, presumably to avoid the problem.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@nx-cloud
Copy link

nx-cloud bot commented Apr 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 925dad6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday
Copy link
Member

@ndelangen I think this is something you were looking at.

@ndelangen ndelangen merged commit eab0fb4 into next Apr 14, 2022
@ndelangen ndelangen deleted the fix-export-of-bundled-theming branch April 14, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook + MUI5 + Nextjs - theme issue?
3 participants