Core: Pre-bundle @storybook/router
#17294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 05c98fc. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
commented
Jan 19, 2022
| NavigateOptions, | ||
| Router, | ||
| } from 'react-router-dom'; | ||
| import * as R from 'react-router-dom'; |
There was a problem hiding this comment.
Renaming exports is just not really supported by the dts-bundle-generator
As discussed @tmeasday we could remove the usage, and use tsc to simply create the deeply nested tree before handing it over to the dts-localizer.
I'm a bit divided on the issue, it's not a great limitation to have, but I really like the output.
# Conflicts: # lib/router/package.json
# Conflicts: # lib/router/package.json
# Conflicts: # lib/router/package.json
# Conflicts: # lib/router/package.json
# Conflicts: # lib/router/package.json
# Conflicts: # lib/router/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16837
This uses #17000 to prebundle
lib/router