Core: Add logLevel preset property to filter logging #10370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
alterx,
dangreenisrael,
igor-dv and
tmeasday
as code owners
ndelangen
changed the title
shilman
changed the title
|
No idea why puppeteer is all of a sudden not able to find the globals anymore, and use them to extract. When I run it locally it works. |
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
it's not used anywhere I think, but we're getting quite a few 'invalid cli option' errors, and this should get rid of them.
tmeasday
reviewed
May 19, 2020
| debug: (message: any, ...rest: any[]): void => console.debug(message, ...rest), | ||
| log: (message: any, ...rest: any[]): void => console.log(message, ...rest), | ||
| log: (message: any, ...rest: any[]): void => window.console.log(message, ...rest), |
There was a problem hiding this comment.
This is pretty surprising, what's up with this?
There was a problem hiding this comment.
console.log has no "level" to it. it's not part of console lib.
I could decide to make log equal to info?
|
@ndelangen I think the most likely situation is that the storybook is throwing an error as it loads in puppeteer and we aren't seeing the error. Try adding: this.page.on('console', (msg) => {
const type = msg.type();
logger.info({ browserConsole: true, type, ...msg.location() }, msg.text());
});Either that or get a build storybook off one of the CI machines (I have one here) |
# Conflicts: # lib/cli/src/extract.ts # lib/client-logger/src/index.ts # yarn.lock
shilman
approved these changes
May 28, 2020
|
I added documentation and the ability to set a value for this from the cli |
This was referenced Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8461
What I did
ADD logLevel preset property (default is
info)ADD global variable injection
ADD filter for lower level log messages
ADD a global method for changing the logLevel at runtime.