Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Log-level is wrong for channel messages and other SB internals #11077

Closed
shilman opened this issue Jun 8, 2020 · 2 comments
Closed

Core: Log-level is wrong for channel messages and other SB internals #11077

shilman opened this issue Jun 8, 2020 · 2 comments

Comments

@shilman
Copy link
Member

shilman commented Jun 8, 2020

#10370 Added loglevel filtering for Storybook, but it doesn't work the way I'd expect it to (and is much less useful than it could be as a result).

Current behavior:
✅ Out of the box, it doesn't show any channel messages
✅ When I set logLevel to debug all of those messages show up
❌ When try to filter out those messages using the browser loglevel, the internal messages are getting logged at at the info level

What I want:

  • Setting the loglevel causes Storybook to emit events "at and above" that loglevel
  • The loglevel doesn't change from older versions of storybook, e.g. internal events are still emitted at the debug level. That way I can easily turn them on and off in the browser and distinguish them from other "more important" events like loglevel was designed for
@ndelangen
Copy link
Member

When try to filter out those messages using the browser loglevel, the internal messages are getting logged at at the info level

sounds like an unexpected bug

@shilman
Copy link
Member Author

shilman commented Jun 11, 2020

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.24 containing PR #11096 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants