Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD a loglevel option for dev mode in CLI #10779

Closed
wants to merge 3 commits into from
Closed

Conversation

ndelangen
Copy link
Member

The loglevel cli options doesn't exists for dev-mode.

I think it should exist.

This doesn't add the feature, it just adds the cli-flag.

We're getting quite a few 'invalid cli option' errors, reported by users, because they try to use this cli-flag for both dev & build mode.

They expect this cli-flag to work for both.

it's not used anywhere I think, but we're getting quite a few 'invalid cli option' errors,
and this should get rid of them.
@ndelangen ndelangen added the bug label May 14, 2020
@ndelangen ndelangen self-assigned this May 14, 2020
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 14, 2020
@ndelangen ndelangen added this to the 5.3.x milestone May 14, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we add the flag without adding the feature?

@ndelangen
Copy link
Member Author

Because at least this means adding --loglevel <something> doesn't make storybook unable to run.

Currently if you pass in this flag, storybook will refuse to run at all.

@ndelangen
Copy link
Member Author

superseded by #10370 for 6.0.0

@ndelangen ndelangen closed this May 29, 2020
@ndelangen ndelangen deleted the tech/loglevel-for-dev branch May 29, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants