Docs not applying base theme in manager.js

[wadehammes]

Describe the bug
Migrating to manager.js has caused Docs to not apply my theme which has a base of 'dark'

To Reproduce
Steps to reproduce the behavior:

1. Create a theme in manager.js and set the base to 'dark'.

Expected behavior
Docs would have a base theme of 'dark' as in 5.2.

Screenshots
Canvas:

Docs:

Code snippets
manager.js

import {addons} from '@storybook/addons';
import {create} from '@storybook/theming/create';
import {APP_COLORS as color} from '../src/styles/colors';

const theme = create({
  base: 'dark',
  colorPrimary: color.SW_SKY_BLUE,
  colorSecondary: color.SW_SKY_BLUE,
});

addons.setConfig({
  theme,
});

System:
Environment Info:

System:
OS: macOS 10.15.2
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.13.0 - ~/.yarn/bin/yarn
npm: 6.13.6 - /usr/local/bin/npm
Browsers:
Chrome: 79.0.3945.117
Firefox: 70.0.1
Safari: 13.0.4
npmPackages:
@storybook/addon-actions: ^5.3.4 => 5.3.4
@storybook/addon-centered: ^5.3.4 => 5.3.4
@storybook/addon-docs: ^5.3.4 => 5.3.4
@storybook/addon-jest: ^5.3.4 => 5.3.4
@storybook/addon-knobs: ^5.3.4 => 5.3.4
@storybook/addon-links: ^5.3.4 => 5.3.4
@storybook/addon-storysource: ^5.3.4 => 5.3.4
@storybook/addons: ^5.3.4 => 5.3.4
@storybook/react: ^5.3.4 => 5.3.4
npmGlobalPackages:
@storybook/cli: 3.4.4

[shilman]

@ndelangen I think this was a case we didn't think through in the theming update 😱

What the heck can we do about it?

[shilman]

Based on discussion with @ndelangen:

In 5.3

• Verify that parameters still works
• Recommend to users (here and in migration/documentation) to use parameters if they're using docs

In 6.0

• Allow specifying manager/preview/(docs?) themes in main.js and recommend that

cc @tmeasday

[tmeasday]

😨

[ndelangen]

I added this to my todo list

[palashkaria]

current workaround: use addParameters -> docs -> container & use Global style from emotion there. A couple of custom overrides

[shilman]

@palashkaria if you use addParameters on options.theme I'd expect it to work in docs without having to do any other workarounds.

[ndelangen]

Recommend to users (here and in migration/documentation) to use parameters if they're using docs

in PR: #9661

[ndelangen]

I'll open a new issue for #9498 (comment)

Allow specifying manager/preview/(docs?) themes in main.js and recommend that