Skip to content

Commit

Permalink
documentation fix #9498 - theming + addon-docs incompatible (#9661)
Browse files Browse the repository at this point in the history
documentation fix #9498 - theming + addon-docs incompatible
  • Loading branch information
ndelangen authored and shilman committed Feb 2, 2020
1 parent 9ec989f commit 205e54a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
2 changes: 2 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ addons.setConfig({
This makes storybook load and use the theme in the manager directly.
This allows for richer theming in the future, and has a much better performance!

> If you're using addon-docs, you should probably not do this. Docs uses the theme as well, but this change makes the theme inaccessible to addon-docs. We'll address this in 6.0.0.
### Create React App preset

You can now move to the new preset for [Create React App](https://create-react-app.dev/). The in-built preset for Create React App will be disabled in Storybook 6.0.
Expand Down
6 changes: 5 additions & 1 deletion addons/docs/docs/theming.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@

Storybook theming is the **recommended way** to theme your docs. If you update your storybook theme according to [the documentation](https://storybook.js.org/docs/configurations/theming/), Storybook Docs should adapt in reasonable ways.

For example, here's how to change your docs (and Storybook) to the dark theme, by modifying `.storybook/preview.js`:
> In the documentation it will say you can theme storybook in `manager.js`, That's a newer more optimal way to theme storybook, but it's currently incompatible with docs.
>
> We're working on making it compatible in 6.0.0, so for now use the method described below.
Here's how to change your docs (and Storybook) to the dark theme, by modifying `.storybook/preview.js`:

```js
import { addParameters } from '@storybook/react';
Expand Down
4 changes: 4 additions & 0 deletions docs/src/pages/configurations/theming/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ title: 'Theming Storybook'

Storybook is theme-able!

> Note that themeing storybook changed recently, to be in `manager.js` (introduced in 5.3). But addon-docs is not yet compatible with this new way of configuring the theme.
>
> See here how to use theme storybook in a way that addon-docs will be themed as well: https://github.com/storybookjs/storybook/tree/master/addons/docs
## Global theming

It's possible to theme Storybook globally.
Expand Down

0 comments on commit 205e54a

Please sign in to comment.