setConfig(theme) in manager.js theme definition not applied to addon-docs

[ndelangen]

As discussed in:
#9498 (comment)

The new method for configuring theme in manager.js unfortunately means addon-docs doesn't receive the theme.

This can be quite disturbing when using dark-mode for example.

We should come up with a good method for sharing the theme / defining it once.

We also discussed to users might actually WANT different themes for manager & docs...

[shubjhamb]

setOptions also didn't work to set theme in docs, If we want to use setOptions in our custom addon to switch theme.

[shilman]

I think we should just set the docs theme independently in the preview, and update the documentation accordingly. WDYT @ndelangen ? If you're good with that solution I can update the documentation.

[ndelangen]

Yeah that would work for me @shilman

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[shilman]

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.26 containing PR #10114 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

[whatwg6]

😔