Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Theme with docs.theme parameter #10114

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Addon-docs: Theme with docs.theme parameter #10114

merged 1 commit into from
Mar 12, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 12, 2020 •
edited
Loading

Issue: #9662

What I did

Support independent theming for docs since the new manager-based theming didn't work anyway for preview-based docs.

  • docs.theme support
  • deprecate options.theme
  • update docs & example

How to test

See official-storybook's preview.js

@shilman shilman requested a review from usulpro as a code owner March 12, 2020 04:00
@shilman shilman modified the milestones: 6.0 breaking changes, 6.0.0 Mar 12, 2020
tmeasday
tmeasday approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 good stuff

@shilman shilman merged commit 2b628d7 into next Mar 12, 2020
@shilman shilman deleted the 9662-docs-theme branch March 12, 2020 08:23
@shilman shilman mentioned this pull request Mar 12, 2020
Closed
@shilman shilman mentioned this pull request Apr 30, 2020
Open
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@usulpro usulpro Awaiting requested review from usulpro

@ndelangen ndelangen Awaiting requested review from ndelangen

@patricklafrance patricklafrance Awaiting requested review from patricklafrance

Assignees
No one assigned
Labels
addon: docs feature request theming
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday