Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.11] Fixing ACM-12888 by supplying a UID for fixed URL ref in the URL #1566

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #1565

/assign moadz

…fana should accept this, provided there is no clash, and the linkref will now reference a fixed dashboard URL instead of a grafana generated UID which changes per-installation.

Also fixed the query param templating for the severity and health impact.

The value of `${severity:queryparam}` already includes the query param tag in it, so the previous template would substitute the tag with `var-health_impact=$var-health_impact=All` instead of `var-health_impact=All`.

Signed-off-by: Moad Zardab <[email protected]>
Copy link

sonarqubecloud bot commented Aug 7, 2024

Copy link

openshift-ci bot commented Aug 7, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e 75e4a4d link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@moadz
Copy link
Contributor

moadz commented Aug 8, 2024

/retest

Copy link

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 8, 2024
@moadz moadz merged commit b59a965 into stolostron:release-2.11 Aug 8, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants