Fixing ACM-12888 by supplying a UID for fixed URL ref in the URL #1565
Conversation
…fana should accept this, provided there is no clash, and the linkref will now reference a fixed dashboard URL instead of a grafana generated UID which changes per-installation.
Also fixed the query param templating for the severity and health impact.
The value of `${severity:queryparam}` already includes the query param tag in it, so the previous template would substitute the tag with `var-health_impact=$var-health_impact=All` instead of `var-health_impact=All`.
Signed-off-by: Moad Zardab <[email protected]>
|
/cherrypick release-2.11 |
|
@moadz: once the present PR merges, I will cherry-pick it on top of release-2.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moadz, philipgough, saswatamcode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@moadz: new pull request created: #1566 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Grafana should accept this, provided there is no clash, and the linkref will now reference a fixed dashboard URL instead of a grafana generated UID which changes per-installation.
Also fixed the query param templating for the severity and health impact.
The value of
${severity:queryparam}already includes the query param tag in it, so the previous template would substitute the tag withvar-health_impact=$var-health_impact=Allinstead ofvar-health_impact=All.