Skip to content

Commit

Permalink
Fixing ACM-12888 by supplying a UID for fixed URL ref in the URL. Gra…
Browse files Browse the repository at this point in the history
…fana should accept this, provided there is no clash, and the linkref will now reference a fixed dashboard URL instead of a grafana generated UID which changes per-installation.

Also fixed the query param templating for the severity and health impact.

The value of `${severity:queryparam}` already includes the query param tag in it, so the previous template would substitute the tag with `var-health_impact=$var-health_impact=All` instead of `var-health_impact=All`.

Signed-off-by: Moad Zardab <[email protected]>
  • Loading branch information
moadz authored and openshift-cherrypick-robot committed Aug 7, 2024
1 parent 274873d commit 75e4a4d
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ data:
"gnetId": null,
"graphTooltip": 0,
"id": 29,
"uid": "OmpD1ZoSk",
"iteration": 1709210609633,
"links": [],
"panels": [
Expand Down Expand Up @@ -357,7 +358,7 @@ data:
"value": [
{
"title": "",
"url": "d/OmpD1ZoSk/openshift-virtualization-overview?${__url_time_range}&orgId=1&var-alert=All&var-severity=$${severity:queryparam}&refresh=5m&var-health_impact=$${health_impact:queryparam}&var-cluster=${__data.fields.Cluster}"
"url": "d/OmpD1ZoSk/openshift-virtualization-overview?${__url_time_range}&orgId=1&var-alert=All&${severity:queryparam}&refresh=5m&${health_impact:queryparam}&var-cluster=${__data.fields.Cluster}"
}
]
}
Expand Down

0 comments on commit 75e4a4d

Please sign in to comment.