Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Fork from Upstream Repo #25

Merged
merged 11 commits into from
Oct 8, 2019
Merged

Sync Fork from Upstream Repo #25

merged 11 commits into from
Oct 8, 2019

Commits on Oct 5, 2019

  1. tidy: split TestRunner to cc (#8500)

    Description:
    - Exclude `modernize-use-trailing-return-type` which is against style guide and noisy even as warning. 
    - Split test_runner to cc and h, anonymous namespace in header results clang-tidy complains non-used function.
    
    Risk Level: Low (test only)
    Testing: CI
    Docs Changes: N/A
    Release Notes: N/A
    
    Signed-off-by: Lizan Zhou <[email protected]>
    lizan authored Oct 5, 2019
    Configuration menu
    Copy the full SHA
    f709434 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2019

  1. api/build: switch to only package level targets in API. (#8495)

    As part of #8082, we want to be able to (1) automatically generate BUILD
    files and (2) treat packages as atomic from a "upgrade / do not upgrade"
    decision perspective. This is simplified by having our BUILD targets at
    package granularity, since this is what the protoxform plugin operates
    on.
    
    This PR broadens the package-level treatment that was already introduced
    for Go in #8003 to Python and C++. This simplifies BUILD files
    significantly and opens the way to automated generation.
    
    There is some technical debt introduced, since all visibility controls
    have been removed. This is slated for reintroduction in
    #8491.
    
    As a bonus (useful for BUILD file generation), also removed the
    inconsistency in BUILD package target naming for packages in envoy.api.*
    and envoy.type.*. E.g. //envoy/api/v2:v2 is now //envoy/api/v2:pkg.
    
    Risk level: Low (but this will break internal builds and require BUILD
    fixups to consuming projects).
    Testing: bazel test //test/... @envoy_api//...
    
    Signed-off-by: Harvey Tuch <[email protected]>
    htuch authored Oct 6, 2019
    Configuration menu
    Copy the full SHA
    4e858f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. tools: refactor .bzl to unify {protoxform,protodoc}.bzl. (#8507)

    This makes it much cheaper in terms of boiler plate to add a new API
    protoc plugin based on the tools/api_proto_plugin framwork. This will be
    used to support an additional plugin to perform API-wide type analysis,
    generating a type upgrade map that will be consumed by protoxform and
    the Envoy binary.
    
    Part of #8082.
    
    Risk level: Low
    Testing: Rebuilt API with protoxform, docs with protodoc.
    
    Signed-off-by: Harvey Tuch <[email protected]>
    htuch authored and lizan committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    0245027 View commit details
    Browse the repository at this point in the history
  2. test: migrate fault filter test configurations to v2 (#8502)

    Description: part of issue #6362
    Risk Level: low
    Testing: existing
    Docs Changes: N/A
    Release Notes: N/A
    
    Signed-off-by: Derek Argueta <[email protected]>
    derekargueta authored and alyssawilk committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    1186716 View commit details
    Browse the repository at this point in the history
  3. Mark Server::InstanceImpl final (#8510)

    Signed-off-by: Yuchen Dai [email protected]
    
    Description:
    Refactor InstanceImpl and remove the only derived test class of InstanceImpl
    Mark entire Server::InstanceImpl as final to avoid accidentally invoke virtual function in InstanceImpl constructor.
    Massage clang-tidy.
    
    Fixes #8509
    
    Signed-off-by: Yuchen Dai <[email protected]>
    lambdai authored and lizan committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    78a6971 View commit details
    Browse the repository at this point in the history
  4. test: use @bazel_tools//tools/cpp/runfiles to find runfiles (#8488)

    Description:
    Proper fix for bazelbuild/bazel#7399 from Envoy side, tests should be aware which workspace its testdata is from. Added parameter to TestEnvironment::runfiles{Path,Directory} to specify `workspace`. Using this ability in compile_time_options CI.
    
    By using `@bazel_tools//tools/cpp/runfiles`, it also allows test binaries to be invoked outside bazel directly, e.g. `bazel-bin/test/exe/main_common_test`, so the GDB wrapper is no longer needed.
    
    Risk Level: Low (test only)
    Testing: CI
    Docs Changes: N/A
    Release Notes: N/A
    
    Signed-off-by: Lizan Zhou <[email protected]>
    lizan authored Oct 7, 2019
    Configuration menu
    Copy the full SHA
    b8212b5 View commit details
    Browse the repository at this point in the history
  5. api/build: automatically generate BUILD files. (#8506)

    This provides canonical BUILD formatting and puts protoxform in charge
    of being able to determine import paths, without having to worry about
    Bazel implications.
    
    Part of #8082.
    
    Risk level: Low
    Testing: tools/proto_sync.py, visual inspection of diffs.
    
    Signed-off-by: Harvey Tuch <[email protected]>
    htuch authored Oct 7, 2019
    Configuration menu
    Copy the full SHA
    e53f40f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. proto_sync: improve error message. (#8527)

    It was previously pointing at proto_sync.py, which is misleading, it's
    necessary to run the full tools/proto_format.sh for a proto fix.
    
    Signed-off-by: Harvey Tuch <[email protected]>
    htuch authored Oct 8, 2019
    Configuration menu
    Copy the full SHA
    632a677 View commit details
    Browse the repository at this point in the history
  2. csrf filter: fix casing of additional origins method (#8511)

    Signed-off-by: Derek Schaller <[email protected]>
    dschaller authored and mattklein123 committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    d695072 View commit details
    Browse the repository at this point in the history
  3. router: set correct timeout for egress->ingress envoys (#8051)

    Signed-off-by: Kateryna Nezdolii <[email protected]>
    Kateryna Nezdolii authored and mattklein123 committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3f7b132 View commit details
    Browse the repository at this point in the history
  4. Bump upstream components (#8516)

    Signed-off-by: William Rowe <[email protected]>
    Signed-off-by: Yechiel Kalmenson <[email protected]>
    achasveachas authored and mattklein123 committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    9c682f8 View commit details
    Browse the repository at this point in the history