Mark Server::InstanceImpl final #8510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
lizan
previously approved these changes
Oct 6, 2019
Signed-off-by: Yuchen Dai <[email protected]>
lizan
approved these changes
Oct 7, 2019
|
@lizan Thank you! |
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
Signed-off-by: Yuchen Dai [email protected] Description: Refactor InstanceImpl and remove the only derived test class of InstanceImpl Mark entire Server::InstanceImpl as final to avoid accidentally invoke virtual function in InstanceImpl constructor. Massage clang-tidy. Fixes envoyproxy#8509 Signed-off-by: Yuchen Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuchen Dai [email protected]
Description:
Refactor InstanceImpl and remove the only derived test class of InstanceImpl
Mark entire Server::InstanceImpl as final to avoid accidentally invoke virtual function in InstanceImpl constructor.
Massage clang-tidy.
Fixes #8509