tools: refactor .bzl to unify {protoxform,protodoc}.bzl. #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it much cheaper in terms of boiler plate to add a new API protoc plugin based on the tools/api_proto_plugin framwork. This will be used to support an additional plugin to perform API-wide type analysis, generating a type upgrade map that will be consumed by protoxform and the Envoy binary. Part of envoyproxy#8082. Risk level: Low Testing: Rebuilt API with protoxform, docs with protodoc. Signed-off-by: Harvey Tuch <[email protected]>
lizan
approved these changes
Oct 7, 2019
nandu-vinodan
pushed a commit
to nandu-vinodan/envoy
that referenced
this pull request
Oct 17, 2019
…8507) This makes it much cheaper in terms of boiler plate to add a new API protoc plugin based on the tools/api_proto_plugin framwork. This will be used to support an additional plugin to perform API-wide type analysis, generating a type upgrade map that will be consumed by protoxform and the Envoy binary. Part of envoyproxy#8082. Risk level: Low Testing: Rebuilt API with protoxform, docs with protodoc. Signed-off-by: Harvey Tuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much cheaper in terms of boiler plate to add a new API
protoc plugin based on the tools/api_proto_plugin framwork. This will be
used to support an additional plugin to perform API-wide type analysis,
generating a type upgrade map that will be consumed by protoxform and
the Envoy binary.
Part of #8082.
Risk level: Low
Testing: Rebuilt API with protoxform, docs with protodoc.
Signed-off-by: Harvey Tuch [email protected]