all: Update libs & tests to support ScValue overhaul.
#4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents. (stellar#4806) * Harden amount parser * Propogate network passphrase and add tests * Integration tests check effect values, passing 🙏 * Move stringification to xdr package * Separate to/from addresses in contract events
Shaptic
force-pushed
the
nextnext/update-ingestion
branch
from
f8c0a72 to
02c5d8a
Compare
Shaptic
commented
Mar 22, 2023
services/horizon/internal/ingest/processors/operations_processor_test.go
Show resolved
Hide resolved
Shaptic
changed the title
ScValue overhaul.
Shaptic
force-pushed
the
nextnext/update-ingestion
branch
from
5880ca8 to
ce35efb
Compare
Shaptic
changed the title
ScValue overhaul.ScValue overhaul.
Shaptic
force-pushed
the
nextnext/update-ingestion
branch
from
cb620b2 to
5278838
Compare
Shaptic
force-pushed
the
nextnext/update-ingestion
branch
from
81fafc5 to
fe74c63
Compare
paulbellamy
reviewed
Mar 23, 2023
|
|
||
| // EffectAccountDebited effects occur when an account sends some currency | ||
| EffectAccountDebited EffectType = 3 // from create_account, payment, path_payment, create_account | ||
| // | ||
| // from create_account, payment, path_payment, create_account, and SAC |
There was a problem hiding this comment.
merge_account as well?
There was a problem hiding this comment.
I dunno, this comment was left as-is. I read it as "the merged account doesn't get a debit effect it just disappears"?
tamirms
reviewed
Mar 23, 2023
tamirms
approved these changes
Mar 23, 2023
tsachiherman
approved these changes
Mar 23, 2023
2opremio
added a commit
that referenced
this pull request
Mar 27, 2023
* Gofmt * update xdr to 7356dc237ee0db5626561c129fb3fa4beaabbac6 * Soroban xdr value overhaul ScVal.Equals fixes (#4815) * Fix a bug in generated xdr for boolean unmarshalling * Output more helpful message when scval test fails * Fix equality for xdr ScVal overhaul * use bytes.equal * soroban-xdr-next-next: Fix txnbuild tests (#4817) * soroban-xdr-next-next: Fix XDR bool encoding/decoding (#4818) * all: Update libs & tests to support `ScVal`ue overhaul. (#4819) * services/horizon: Add `account_credited`/`debited` effects for SAC events. (#4806) * Include contract asset balance changes in payments (#4807) * all: Bump supported Go versions to 1.19 and 1.20. (#4810) * Use version 0.7.0 and 8abd3353c728f09ee1c8a2544f67a853e915afc2 of rs-soroban-sdk dependency * Embed XDR into a separate file for testing --------- Co-authored-by: shawn <[email protected]> Co-authored-by: tamirms <[email protected]> * ingest: Extract diagnostic events in GetOperationEvents() (#4820) --------- Co-authored-by: Alfonso Acosta <[email protected]> Co-authored-by: George <[email protected]> Co-authored-by: shawn <[email protected]> Co-authored-by: tamirms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates things to conform to the new way to build
ScVals:support/contracteventslibrary, which parses SAC eventscontract_data.goingestion processor, which parses contractsoperations_processor_test.go,invoke_host_function_test.goandsac_test.gotest suites to properly build contract invocationsWhy
Self-explanatory: stellar/stellar-cli#471.
Closes #4790.
Known limitations
n/a