Soroban xdr value overhaul ScVal.Equals fixes #4815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Mar 17, 2023
| @@ -51046,7 +51046,7 @@ func (u *ScVal) DecodeFrom(d *xdr.Decoder) (int, error) { | |||
| switch ScValType(u.Type) { | |||
| case ScValTypeScvBool: | |||
| u.B = new(bool) | |||
| nTmp, err = d.Decode((*u.B)) | |||
| nTmp, err = d.Decode(u.B) | |||
There was a problem hiding this comment.
Did you fix this in xdrgen?
There was a problem hiding this comment.
Not yet. stellar/xdrgen#154
There was a problem hiding this comment.
There's another problem at:
func (s *DiagnosticEvent) DecodeFrom(d *xdr.Decoder) (int, error) {
var err error
var n, nTmp int
nTmp, err = d.Decode(s.InSuccessfulContractCall)
There was a problem hiding this comment.
I think we simply need to add bool support to xdrgen
2opremio
reviewed
Mar 17, 2023
2opremio
approved these changes
Mar 17, 2023
Shaptic
reviewed
Mar 17, 2023
Shaptic
reviewed
Mar 17, 2023
Shaptic
approved these changes
Mar 20, 2023
|
Just to get the cross-reference: this partially closes #4791. |
2opremio
added a commit
that referenced
this pull request
Mar 27, 2023
* Gofmt * update xdr to 7356dc237ee0db5626561c129fb3fa4beaabbac6 * Soroban xdr value overhaul ScVal.Equals fixes (#4815) * Fix a bug in generated xdr for boolean unmarshalling * Output more helpful message when scval test fails * Fix equality for xdr ScVal overhaul * use bytes.equal * soroban-xdr-next-next: Fix txnbuild tests (#4817) * soroban-xdr-next-next: Fix XDR bool encoding/decoding (#4818) * all: Update libs & tests to support `ScVal`ue overhaul. (#4819) * services/horizon: Add `account_credited`/`debited` effects for SAC events. (#4806) * Include contract asset balance changes in payments (#4807) * all: Bump supported Go versions to 1.19 and 1.20. (#4810) * Use version 0.7.0 and 8abd3353c728f09ee1c8a2544f67a853e915afc2 of rs-soroban-sdk dependency * Embed XDR into a separate file for testing --------- Co-authored-by: shawn <[email protected]> Co-authored-by: tamirms <[email protected]> * ingest: Extract diagnostic events in GetOperationEvents() (#4820) --------- Co-authored-by: Alfonso Acosta <[email protected]> Co-authored-by: George <[email protected]> Co-authored-by: shawn <[email protected]> Co-authored-by: tamirms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fix the ScVal.Equals method for the soroban xdr value overhaul.
Why
Part of stellar/stellar-cli#477
Needed for #4789, because this change gets the
xdrpackage compiling and passing it's own tests.Known limitations
[TODO or N/A]