Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contractevent, services/horizon: Update Stellar Asset Contract event parsing and testing. #4790

Closed
4 tasks done
tsachiherman opened this issue Mar 6, 2023 · 2 comments
Closed
4 tasks done

contractevent, services/horizon: Update Stellar Asset Contract event parsing and testing. #4790

tsachiherman opened this issue Mar 6, 2023 · 2 comments
Assignees
@Shaptic
Labels
soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023 •
edited by Shaptic
Loading

Epic: stellar/stellar-cli#471

What?

TL;DR: Update SAC event processing for new ScVal format.

This is a significant piece of work because there are two large components:

  • Updating the new support/contractevent library (ingest: Move SAC event parsing to its own package, add more events. #4802) to parse SAC events in their new format
  • Updating the integration/sac_test.go test suite to ensure we properly interact with the SAC
  • Updating the integration/invoke_host_function.go test suite
  • Updating the contract data processor (ingest/processors/contract_data.go)
@tsachiherman tsachiherman mentioned this issue Mar 6, 2023
Closed
@Shaptic
Copy link
Contributor

Shaptic commented Mar 9, 2023

@tamirms would you mind/want to switch this for one of mine? Since I'm actively working on event parsing I might have an easier time fighting the new XDR

@tamirms
Copy link
Contributor

tamirms commented Mar 10, 2023

no problem, I'll assign this to you

@tamirms tamirms assigned Shaptic and unassigned tamirms Mar 10, 2023
@Shaptic Shaptic changed the title horizon: Update SAC event processing for new ScVal parsing contractevent, services/horizon: Update Stellar Asset Contract event parsing and testing. Mar 10, 2023
@mollykarcher mollykarcher moved this from Backlog to Current Sprint in Platform Scrum Mar 20, 2023
@Shaptic Shaptic self-assigned this Mar 20, 2023
@Shaptic Shaptic moved this from Current Sprint to In Progress in Platform Scrum Mar 20, 2023
This was referenced Mar 20, 2023
Closed
Merged
@Shaptic Shaptic closed this as completed Mar 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Shaptic @tamirms @tsachiherman