services/horizon: Refactor handling of stellar-core-binary-path #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Containers and configurations should be allowed to set `--stellar-core-binary-path` regardless of the behavior we want from Horizon. 1. Do not assume that a non-empty `--stellar-core-binary-path` (or `--remote-captive-core-url`) implies captive core should be used (use the pre-existing `--enable-captive-core-ingestion` as a tollgate instead). 2. Allow setting both `--remote-captive-core-url` and `--stellar-core-binary-path` simultaneously, associating a higher priority to the URL.
2opremio
force-pushed
the
fix-captive-core-flag-utilization
branch
from
b7cec24 to
6f45d4a
Compare
tamirms
approved these changes
Oct 6, 2020
This was referenced Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers and configurations should be allowed to set
--stellar-core-binary-pathregardless of the behavior we want from Horizon.--stellar-core-binary-path(or--remote-captive-core-url) implies captive core should be used (use the pre-existing--enable-captive-core-ingestionas a tollgate instead).--remote-captive-core-urland--stellar-core-binary-pathsimultaneously, associating a higher priority to the URL.Fixes #2973