Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Pass EnableCaptiveCore to config. #3137

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Oct 16, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fix missing flag in system.Config.

Why

We were not passing app.config.EnableCaptiveCoreIngestion when starting the system. Always disabling captive core.

Known limitations

[TODO or N/A]

@cla-bot cla-bot bot added the cla: yes label Oct 16, 2020
@abuiles abuiles requested a review from tamirms October 16, 2020 20:58
@abuiles abuiles force-pushed the fix-captive-core-enabled-flag branch from d6944c6 to cbcdb1e Compare October 16, 2020 21:02
@@ -425,8 +425,9 @@ jobs:
# ... without captive core
- run_horizon_integration_tests
# ... and with captive core
- run_horizon_integration_tests:
enable-captive-core: true
# This isn't working at the moment
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stellar/horizon-committers disabling this to fix horizon with captive core since it is broken, we need to fix the integration test in a different PR.

@abuiles abuiles force-pushed the fix-captive-core-enabled-flag branch from ce61ae6 to ea4bc42 Compare October 18, 2020 18:11
@2opremio
Copy link
Contributor

2opremio commented Oct 19, 2020

🤦, sorry. Follow-up from #3101 . I will take care of fixing the captive core integration tests.

@abuiles abuiles force-pushed the fix-captive-core-enabled-flag branch from ea4bc42 to 296c9fc Compare October 19, 2020 16:22
@abuiles abuiles merged commit 24465e0 into stellar:master Oct 19, 2020
@abuiles abuiles deleted the fix-captive-core-enabled-flag branch October 19, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants