Add support for captive core (standalone) and manual close #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: for now this only works with Horizon's master, because (before stellar/go#3101 ) |
bartekn
approved these changes
Oct 27, 2020
| if [ "$NETWORK" != "standalone" ] && [ "$ENABLE_HORIZON_CAPTIVE_CORE" = "true" ]; then | ||
| echo "--enable-horizon-captive-core is only supported in the standalone network" >&2 | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Shouldn't we have the same check for ENABLE_CORE_MANUAL_CLOSE?
There was a problem hiding this comment.
No, that should work for all networks
This has been addressed by 3df870e |
2opremio
force-pushed
the
support-captive-core-and-manual-close
branch
from
40d43b4 to
3df870e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Horizon's captive-core mode (only in the standalone network for now) and Core's Manual close mode.
Both are needed in the context of stellar/go#3153 . More context at stellar/go#3144 (comment)